Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flexible size #32

Merged
merged 7 commits into from
Sep 24, 2024
Merged

add flexible size #32

merged 7 commits into from
Sep 24, 2024

Conversation

hugo-clemente
Copy link
Contributor

Hey,
First of all thanks for the work, just wanted to add the flexible size, but had to update the turnstile-types.
I read in the previous PR that you wanted to preserve the invisible option, but that makes the types inconsistent between react-turnstile and turnstile-types so i chose to remove it.

@Le0Developer
Copy link
Owner

expired-callback does actually get the current token as a parameter. Must've forgotten it in turnstile-types, will push an update to it soon™️. See below from api.js:
image

Also your style override for width/height is in conflict/duplicated by the fixedSize prop.

@Le0Developer
Copy link
Owner

I've released v1.2.3 of turnstile-types which adds invisible to size and token to expired-callback

@hugo-clemente
Copy link
Contributor Author

Yeah sorry had a few back and forth with myself... 😅
It should be good now though, used the updated version of turnstile-types, and fixed the issue with the fixedSized prop

@Le0Developer
Copy link
Owner

Last missing piece is an entry in HISTORY.md 🙏

@hugo-clemente
Copy link
Contributor Author

Done !

Le0Developer
Le0Developer approved these changes Sep 24, 2024
View reviewed changes
Copy link
Owner

@Le0Developer Le0Developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm puzzled by the CI failure, it's fine locally.
I suspect it might be because the CI is running node 18 and thus runs an older prettier version that still supports it, but I'll fix that in a separate PR.

@Le0Developer Le0Developer merged commit 133408a into Le0Developer:main Sep 24, 2024
1 check failed
@Le0Developer Le0Developer mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Le0Developer Le0Developer Le0Developer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugo-clemente @Le0Developer